Enable Isolate Extensions by default.

Enable Isolate Extensions by default.

This CL enables Isolate Extensions by default, even when field trial
config is not present. The supporting code for the field trial config
will be removed in a follow up CL.

BUG=545200
Review-Url: https://codereview.chromium.org/2715363002
Cr-Commit-Position: refs/heads/master@{#453318}
Committed: https://chromium.googlesource.com/chromium/src/+/9e1897b5c7dab9c190fc3c919a1c4662af63b3e6

[nasko, 2017-02-27 19:04:03]

nasko@chromium.org changed reviewers:
+ creis@chromium.org, nick@chromium.org, rdevlin.cronin@chromium.org

[nasko, 2017-02-27 19:04:04]

Hey everyone,
Can you review this CL for me? It enables Isolate Extensions to be on by default
even in the absence of field trial configuration. It is a prep step before fully
removing the config code.
Thanks in advance!
Nasko

[nasko, 2017-02-27 19:04:19]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 19:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2017-02-27 19:11:38]

LGTM!

[Devlin, 2017-02-27 19:27:23]

https://codereview.chromium.org/2715363002/diff/1/chrome/common/extensions/ex...
File chrome/common/extensions/extension_process_policy.cc (right):

https://codereview.chromium.org/2715363002/diff/1/chrome/common/extensions/ex...
chrome/common/extensions/extension_process_policy.cc:86: if (control_group ||
default_group)
It's strange to me that the default_group behavior doesn't match the "default"
behavior - is this intentional?  Do we have a default group with a population? 
If not, I think it'd make more sense to only gate on Control.

[nasko, 2017-02-27 19:35:14]

https://codereview.chromium.org/2715363002/diff/1/chrome/common/extensions/ex...
File chrome/common/extensions/extension_process_policy.cc (right):

https://codereview.chromium.org/2715363002/diff/1/chrome/common/extensions/ex...
chrome/common/extensions/extension_process_policy.cc:86: if (control_group ||
default_group)
On 2017/02/27 19:27:22, Devlin wrote:
> It's strange to me that the default_group behavior doesn't match the "default"
> behavior - is this intentional?  Do we have a default group with a population?

> If not, I think it'd make more sense to only gate on Control.

Yes, naming is hard ... the "default" group should've been called a "remainder"
group, which is the part of the population that wasn't either Control or
Enabled. Default group removed.

[Devlin, 2017-02-27 19:36:07]

lgtm

[nasko, 2017-02-27 19:39:01]

The CQ bit was checked by nasko@chromium.org

[nasko, 2017-02-27 19:39:02]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2715363002/#ps20001
(title: "Remove check for 'Default' group")

[commit-bot: I haz the power, 2017-02-27 19:39:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:28:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488224341930940,
"parent_rev": "09ac3a21d0b908ca26d0898f58ea77be7e9462d2", "commit_rev":
"9e1897b5c7dab9c190fc3c919a1c4662af63b3e6"}

[commit-bot: I haz the power, 2017-02-27 20:29:33]

Description was changed from

==========
Enable Isolate Extensions by default.

This CL enables Isolate Extensions by default, even when field trial
config is not present. The supporting code for the field trial config
will be removed in a follow up CL.

BUG=545200
==========

to

==========
Enable Isolate Extensions by default.

This CL enables Isolate Extensions by default, even when field trial
config is not present. The supporting code for the field trial config
will be removed in a follow up CL.

BUG=545200

Review-Url: https://codereview.chromium.org/2715363002
Cr-Commit-Position: refs/heads/master@{#453318}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e1897b5c7dab9c190fc3c919a1c...
==========

[commit-bot: I haz the power, 2017-02-27 20:29:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9e1897b5c7dab9c190fc3c919a1c...