Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2715353003: Allow clicks > 1 to navigate. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow clicks > 1 to navigate. Due to a few breakages revert change crrev.com/e46f8fbfd5d2d3408d09d4262fb0f4f99c93a98f Invert the layout test to ensure we have consistent behaviour. BUG=658904 Review-Url: https://codereview.chromium.org/2715353003 Cr-Commit-Position: refs/heads/master@{#453348} Committed: https://chromium.googlesource.com/chromium/src/+/917d0b3de410cd7efc197b275ffb5d1f3ddba5b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/html/text-level-semantics/a-click.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dtapuska
3 years, 9 months ago (2017-02-27 18:29:41 UTC) #4
Rick Byers
LGTM
3 years, 9 months ago (2017-02-27 21:38:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715353003/1
3 years, 9 months ago (2017-02-27 21:44:19 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 21:54:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/917d0b3de410cd7efc197b275ffb...

Powered by Google App Engine
This is Rietveld 408576698