Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2715353002: Fix LayoutTreeBuilderTraversal limit checks when recursing. (Closed)

Created:
3 years, 9 months ago by emilio
Modified:
3 years, 9 months ago
Reviewers:
rune
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LayoutTreeBuilderTraversal limit checks when recursing. Before this commit, we were checking for limit == 0, which is wrong given we postdecrement (so when we actually run out of siblings we should keep limit equal to -1). BUG=657748 TEST=third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversalTest.cpp Review-Url: https://codereview.chromium.org/2715353002 Cr-Commit-Position: refs/heads/master@{#453435} Committed: https://chromium.googlesource.com/chromium/src/+/090729aac055ae7eb04e6056ef27f6affc9ee893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversalTest.cpp View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
emilio
Hi rune, please take a look, this is split from https://codereview.chromium.org/2719713002/
3 years, 9 months ago (2017-02-27 18:20:21 UTC) #3
rune
lgtm
3 years, 9 months ago (2017-02-27 23:16:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715353002/1
3 years, 9 months ago (2017-02-27 23:39:55 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 01:21:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/090729aac055ae7eb04e6056ef27...

Powered by Google App Engine
This is Rietveld 408576698