Oilpan: Prepare to move FormAssociatedElement to Oilpan heap, part 1.

Oilpan: Prepare to move FormAssociatedElement to Oilpan heap, part 1.

FormAssociatedElement should be GarbageCollectedMixin, and this CL replaces
existing RefPtr<FormAssociatedElement> with Oilpan transition types.

This CL doesn't handle existing FormAssociatedElement raw pointers. The next CL
will handle them.

This CL moves ValidityState to Oilpan heap because ValidityState depends on
FormAssociatedElement::ref() and deref().

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173634

[tkent, 2014-05-08 06:47:35]

Please review this.

[haraken, 2014-05-08 07:24:45]

LGTM

https://codereview.chromium.org/271533009/diff/20001/Source/core/html/HTMLObj...
File Source/core/html/HTMLObjectElement.h (right):

https://codereview.chromium.org/271533009/diff/20001/Source/core/html/HTMLObj...
Source/core/html/HTMLObjectElement.h:39: using HTMLPlugInElement::trace;

Do you need this? I wonder why you need the using in HTMLObjectElement but don't
need the using in HTMLFormControlElement.

[Mads Ager (chromium), 2014-05-08 07:36:23]

LGTM2

[zerny-chromium, 2014-05-08 07:48:24]

lgtm with a nit

https://codereview.chromium.org/271533009/diff/20001/Source/core/html/Validit...
File Source/core/html/ValidityState.h (right):

https://codereview.chromium.org/271533009/diff/20001/Source/core/html/Validit...
Source/core/html/ValidityState.h:33: class ValidityState : public
NoBaseWillBeGarbageCollectedFinalized<ValidityState>, public ScriptWrappable {
This can just be GarbageCollected<>

[haraken, 2014-05-08 08:00:33]

https://codereview.chromium.org/271533009/diff/20001/Source/core/html/Validit...
File Source/core/html/ValidityState.h (right):

https://codereview.chromium.org/271533009/diff/20001/Source/core/html/Validit...
Source/core/html/ValidityState.h:33: class ValidityState : public
NoBaseWillBeGarbageCollectedFinalized<ValidityState>, public ScriptWrappable {
On 2014/05/08 07:48:24, zerny-chromium wrote:
> This can just be GarbageCollected<>

Unfortunately no, due to ScriptWrappable :)

[tkent, 2014-05-08 08:15:32]

https://codereview.chromium.org/271533009/diff/20001/Source/core/html/HTMLObj...
File Source/core/html/HTMLObjectElement.h (right):

https://codereview.chromium.org/271533009/diff/20001/Source/core/html/HTMLObj...
Source/core/html/HTMLObjectElement.h:39: using HTMLPlugInElement::trace;
On 2014/05/08 07:24:45, haraken wrote:
> 
> Do you need this? I wonder why you need the using in HTMLObjectElement but
don't
> need the using in HTMLFormControlElement.

Ah, it's unnecessary.  Probably I was confused during the development.

[tkent, 2014-05-08 08:41:04]

The CQ bit was checked by tkent@chromium.org

[tkent, 2014-05-08 08:41:08]

The CQ bit was unchecked by tkent@chromium.org

[commit-bot: I haz the power, 2014-05-08 08:41:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/271533009/40001

[tkent, 2014-05-08 08:42:41]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-05-08 08:43:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/271533009/40001

[commit-bot: I haz the power, 2014-05-08 10:05:33]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/6622)

[commit-bot: I haz the power, 2014-05-08 10:54:17]

Change committed as 173634