Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: Source/core/html/FormAssociatedElement.h

Issue 271533009: Oilpan: Prepare to move FormAssociatedElement to Oilpan heap, part 1. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove using Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/FormAssociatedElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/FormAssociatedElement.h
diff --git a/Source/core/html/FormAssociatedElement.h b/Source/core/html/FormAssociatedElement.h
index 656629992166ca44ea7188d08dde8a45f276b353..ecc9f625ddd3683b31aeb339e651491b00e3ec47 100644
--- a/Source/core/html/FormAssociatedElement.h
+++ b/Source/core/html/FormAssociatedElement.h
@@ -24,6 +24,7 @@
#ifndef FormAssociatedElement_h
#define FormAssociatedElement_h
+#include "platform/heap/Handle.h"
#include "wtf/WeakPtr.h"
#include "wtf/text/WTFString.h"
@@ -40,12 +41,14 @@ class ValidationMessage;
class ValidityState;
class VisibleSelection;
-class FormAssociatedElement {
+class FormAssociatedElement : public WillBeGarbageCollectedMixin {
public:
virtual ~FormAssociatedElement();
+#if !ENABLE(OILPAN)
void ref() { refFormAssociatedElement(); }
void deref() { derefFormAssociatedElement(); }
+#endif
static HTMLFormElement* findAssociatedForm(const HTMLElement*);
HTMLFormElement* form() const { return m_form.get(); }
@@ -90,6 +93,7 @@ public:
protected:
FormAssociatedElement();
+ void trace(Visitor*);
void insertedInto(ContainerNode*);
void removedFrom(ContainerNode*);
void didMoveToNewDocument(Document& oldDocument);
@@ -109,16 +113,21 @@ protected:
String customValidationMessage() const;
private:
+#if !ENABLE(OILPAN)
virtual void refFormAssociatedElement() = 0;
virtual void derefFormAssociatedElement() = 0;
+#endif
void setFormAttributeTargetObserver(PassOwnPtr<FormAttributeTargetObserver>);
void resetFormAttributeTargetObserver();
OwnPtr<FormAttributeTargetObserver> m_formAttributeTargetObserver;
- // m_form should be a strong reference in Oilpan.
+#if ENABLE(OILPAN)
+ Member<HTMLFormElement> m_form;
+#else
WeakPtr<HTMLFormElement> m_form;
- OwnPtr<ValidityState> m_validityState;
+#endif
+ OwnPtrWillBeMember<ValidityState> m_validityState;
String m_customValidationMessage;
bool m_formWasSetByParser;
};
« no previous file with comments | « no previous file | Source/core/html/FormAssociatedElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698