Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2715323002: Add XStream to Chromium third_party. (Closed)

Created:
3 years, 9 months ago by mikecase (-- gone --)
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add XStream to Chromium third_party. This is a new dependency for Robolectric 3.2. BUG=693659 Review-Url: https://codereview.chromium.org/2715323002 Cr-Commit-Position: refs/heads/master@{#453736} Committed: https://chromium.googlesource.com/chromium/src/+/66ab3f4789a3ee5592027963a3660ec20de8503a

Patch Set 1 #

Patch Set 2 : Fix year in copyright thing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/xstream/BUILD.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/xstream/LICENSE View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/xstream/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/xstream/README.chromium View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/xstream/lib/xstream-1.4.8.jar.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mikecase (-- gone --)
Want to add Xstream to third_party/. This is a new dependency for Robolectric (am looking ...
3 years, 9 months ago (2017-02-27 17:59:56 UTC) #2
the real yoland
lgtm
3 years, 9 months ago (2017-02-27 22:02:35 UTC) #3
klobag.chromium
lgtm
3 years, 9 months ago (2017-02-28 20:16:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715323002/20001
3 years, 9 months ago (2017-02-28 21:11:52 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:21:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/66ab3f4789a3ee5592027963a366...

Powered by Google App Engine
This is Rietveld 408576698