Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2715243009: MD Settings: Add placeholder text when adding/editing a content exception. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
dschuyler, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add placeholder text when adding/editing a content exception. BUG=657639 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2715243009 Cr-Commit-Position: refs/heads/master@{#453506} Committed: https://chromium.googlesource.com/chromium/src/+/a92b519592dabba45a0e7f0bd2b52f9e33a7ae75

Patch Set 1 #

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/add_site_dialog.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/edit_exception_dialog.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
dpapad
Before/after screenshots http://imgur.com/a/c5HYs.
3 years, 9 months ago (2017-02-28 02:01:07 UTC) #6
dschuyler
lgtm
3 years, 9 months ago (2017-02-28 02:13:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715243009/20001
3 years, 9 months ago (2017-02-28 02:20:25 UTC) #10
Dan Beam
this come up in one of my later meetings today, thanks for fixing :) lgtm
3 years, 9 months ago (2017-02-28 03:20:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/23305)
3 years, 9 months ago (2017-02-28 03:34:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715243009/20001
3 years, 9 months ago (2017-02-28 04:19:28 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 05:06:58 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a92b519592dabba45a0e7f0bd2b5...

Powered by Google App Engine
This is Rietveld 408576698