Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2715243007: Remove baselines in external/wpt that are now considered all-PASS. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
tkent, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove baselines in external/wpt that are now considered all-PASS. Background: for https://crbug.com/687492, I simplified the logic that determines whether a baseline is considered "all-PASS" so that as long as there's at least one PASS and no FAIL, then it's all-PASS, even if some of the test descriptions take multiple lines. This change removes baselines that are now considered "all-PASS"; this shouldn't affect whether any tests pass or fail. BUG=687492 Review-Url: https://codereview.chromium.org/2715243007 Cr-Commit-Position: refs/heads/master@{#453609} Committed: https://chromium.googlesource.com/chromium/src/+/8b9268f9f83df19ad02d9d45d7b37f2616a88c93

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
qyearsley
3 years, 9 months ago (2017-02-27 21:22:26 UTC) #2
tkent
lgtm
3 years, 9 months ago (2017-02-28 04:27:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715243007/1
3 years, 9 months ago (2017-02-28 15:56:44 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 16:01:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b9268f9f83df19ad02d9d45d7b3...

Powered by Google App Engine
This is Rietveld 408576698