third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp - Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)

Patch Set: add unit test for remote frame transparency Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

index 52bc9e2124c109d027365d020fb8aa7cadfe312c..7ca766fee704b20b58fc34b2df01db29e05f9e6e 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

@@ -51,6 +51,7 @@

#include "platform/LengthFunctions.h"

#include "platform/ScriptForbiddenScope.h"

#include "platform/geometry/IntRect.h"

+#include "platform/graphics/Color.h"

#include "platform/graphics/GraphicsContext.h"

#include "platform/graphics/ImageBuffer.h"

#include "platform/graphics/ImageObserver.h"

@@ -668,7 +669,7 @@ Image::SizeAvailability SVGImage::dataChanged(bool allDataReceived) {

// thus never see scrollbars.

frame->view()->setCanHaveScrollbars(false);

// SVG Images are transparent.

- frame->view()->setTransparent(true);

+ frame->view()->setBaseBackgroundColor(Color::transparent);

m_page = page;