third_party/WebKit/Source/core/paint/ViewPainter.cpp - Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ViewPainter.cpp

Issue 2715243004: [blink] Support (semi-)transparent background colors in WebView/Frame. (Closed)

Patch Set: add unit test for remote frame transparency Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/ViewPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/ViewPainter.cpp b/third_party/WebKit/Source/core/paint/ViewPainter.cpp

index 1b2d2fea3c3b90437f8d95eea680874fb5955f33..6d53b15a80771a9bb20178c60991b71eff3c22d4 100644

--- a/third_party/WebKit/Source/core/paint/ViewPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/ViewPainter.cpp

@@ -86,7 +86,8 @@ void ViewPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo) {

const Document& document = m_layoutView.document();

const FrameView& frameView = *m_layoutView.frameView();

bool isMainFrame = document.isInMainFrame();

- bool paintsBaseBackground = isMainFrame && !frameView.isTransparent();

+ bool paintsBaseBackground =

+ isMainFrame && (frameView.baseBackgroundColor().alpha() > 0);

bool shouldClearCanvas =

paintsBaseBackground &&

(document.settings() &&