Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2715223003: Revert "[SAB] Move Atomics builtins to C++" (Closed)

Created:
3 years, 9 months ago by binji
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

This is a speculative chain of reverts to improve a Chrome perf regression. See crbug.com/695653 for more info. Revert "[SAB] Move Atomics builtins to C++" This reverts commit 2b9840d86f3b51f42918b6bf1a06ff8b62b2464d. Revert "[SAB] Remove unreachable Uint8Clamped atomics paths" This reverts commit d1160fb14f767f230f4d276b4bef49f846bb7a94. Revert "Remove tiny unit test for MinSimple/MaxSimple" This reverts commit 837760ecb7ff2ccaf7921ab46e7b473b313d4a4d. Revert "Remove infrastructure for experimental JS natives" This reverts commit 8cfe45b6f1880008d09d4310458b6e6fcb0522dd. BUG=695653 TBR=hablich@chromium.org Review-Url: https://codereview.chromium.org/2715223003 Cr-Commit-Position: refs/heads/master@{#43462} Committed: https://chromium.googlesource.com/v8/v8/+/5a04f4fd68d1d35d704cdc0dee0719c5354a8094

Patch Set 1 #

Patch Set 2 : another CL to revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1083 lines, -716 lines) Patch
M BUILD.gn View 8 chunks +44 lines, -0 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 10 chunks +93 lines, -26 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 2 chunks +0 lines, -661 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +11 lines, -4 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A src/js/harmony-atomics.js View 1 chunk +160 lines, -0 lines 0 comments Download
M src/js/prologue.js View 1 5 chunks +100 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 2 chunks +539 lines, -0 lines 0 comments Download
M src/runtime/runtime-futex.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/snapshot/natives.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/snapshot/natives-common.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/snapshot/natives-external.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M src/v8.gyp View 5 chunks +41 lines, -0 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/futex.js View 1 chunk +0 lines, -8 lines 0 comments Download
A test/mjsunit/minmax-simple.js View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
binji
3 years, 9 months ago (2017-02-27 20:42:51 UTC) #1
binji
3 years, 9 months ago (2017-02-27 20:44:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715223003/20001
3 years, 9 months ago (2017-02-27 22:24:28 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:26:35 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5a04f4fd68d1d35d704cdc0dee0719c5354...

Powered by Google App Engine
This is Rietveld 408576698