Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2715213003: Use independent property inheritance fast-path for text-align. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
Reviewers:
napper, sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use independent property inheritance fast-path for text-align. This was originally attempted in [1], but the custom function for applying text-align values did not clear the inherited bit. Added a test to the framework to catch the case for trying to propagate a value down to a descendant with the property explicitly set. [1] https://codereview.chromium.org/2628503002/ R=sashab@chromium.org,napper@chromium.org BUG=628043, 686585 Review-Url: https://codereview.chromium.org/2715213003 Cr-Commit-Position: refs/heads/master@{#453430} Committed: https://chromium.googlesource.com/chromium/src/+/21ca7c7f71295c31a418e6dfe5dc03148e7bb9b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
rune
ptal
3 years, 9 months ago (2017-02-27 14:38:44 UTC) #3
sashab
LGTM!! Well done rune :D Great find, thanks for the repro case too
3 years, 9 months ago (2017-02-27 23:28:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715213003/1
3 years, 9 months ago (2017-02-28 00:56:14 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 01:08:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21ca7c7f71295c31a418e6dfe5dc...

Powered by Google App Engine
This is Rietveld 408576698