Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2715153003: Implement 'normal', 'strict', and 'loose' of the 'line-break' property (Closed)

Created:
3 years, 9 months ago by kojii
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement 'normal', 'strict', and 'loose' of the 'line-break' property This patch implements the 3 values of the 'line-break' property[1] using the CLDR text break variants in locale IDs[2]. This is the same way as WebKit supports these 3 values. This patch fixes 82 test failures in csswg-test. 43 tests still fail, they are to be investigated. This patch relies on ICU to have necessary data. ICU is working on its efficiency further[3]. [1] https://drafts.csswg.org/css-text-3/#line-break-property [2] http://cldr.unicode.org/development/development-process/design-proposals/specifying-text-break-variants-in-locale-ids [3] http://bugs.icu-project.org/trac/ticket/11530 BUG=306730 Review-Url: https://codereview.chromium.org/2715153003 Cr-Commit-Position: refs/heads/master@{#453809} Committed: https://chromium.googlesource.com/chromium/src/+/73f7033f99cd065bb7fb7531c8dc3cb2b115fd5e

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : Rebased on imported csswg-test #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -87 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 2 chunks +0 lines, -82 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 2 3 4 3 chunks +28 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutLocale.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutLocale.cpp View 1 4 2 chunks +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutLocaleTest.cpp View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
kojii
PTAL.
3 years, 9 months ago (2017-02-28 21:49:37 UTC) #8
eae
LGTM
3 years, 9 months ago (2017-02-28 22:37:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715153003/80001
3 years, 9 months ago (2017-03-01 02:29:24 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:07:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/73f7033f99cd065bb7fb7531c8dc...

Powered by Google App Engine
This is Rietveld 408576698