Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2715093002: Add back use of --auth-refresh-token-json for wpt-import (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
Vadim Sh., wkorman
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add back use of --auth-refresh-token-json for wpt-import This is required for authentication with buildbucket currently, and thus required for triggering try jobs, see http://crbug.com/693792 BUG=693792 Review-Url: https://codereview.chromium.org/2715093002 Cr-Commit-Position: refs/heads/master@{#453271} Committed: https://chromium.googlesource.com/chromium/src/+/61c0a31a9889b25af7c5d05edea59a59f04fdffa

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change command list to just try. #

Patch Set 3 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py View 1 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py View 1 2 1 chunk +13 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
qyearsley
3 years, 9 months ago (2017-02-26 19:18:58 UTC) #7
Vadim Sh.
lgtm https://codereview.chromium.org/2715093002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py File third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py (right): https://codereview.chromium.org/2715093002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py#newcode21 third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py:21: _COMMANDS_THAT_TAKE_REFRESH_TOKEN = ( I think this should be ...
3 years, 9 months ago (2017-02-26 21:47:05 UTC) #8
qyearsley
https://codereview.chromium.org/2715093002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py File third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py (right): https://codereview.chromium.org/2715093002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py#newcode21 third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py:21: _COMMANDS_THAT_TAKE_REFRESH_TOKEN = ( On 2017/02/26 at 21:47:05, Vadim Sh. ...
3 years, 9 months ago (2017-02-27 16:20:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715093002/40001
3 years, 9 months ago (2017-02-27 17:36:13 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 18:40:42 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/61c0a31a9889b25af7c5d05edea5...

Powered by Google App Engine
This is Rietveld 408576698