Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2715063002: net: remove CryptoModuleList typedef (Closed)

Created:
3 years, 10 months ago by mattm
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, dbeam+watch-options_chromium.org, cbentzel+watch_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, net-reviews_chromium.org, bnc+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: remove CryptoModuleList typedef Fixes ListModules() TODO in net/cert/nss_cert_database.h. Based on patch from tfarina (http://crrev.com/2711113002#ps60001). BUG=488586 TEST=net_unittests

Patch Set 1 : patch from issue 2711113002 at patchset 60001 (http://crrev.com/2711113002#ps60001) #

Patch Set 2 : use std::move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -60 lines) Patch
M chrome/browser/certificate_manager_model.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/crypto_module_password_dialog_nss.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/crypto_module_password_dialog_nss.cc View 1 9 chunks +17 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/certificates_handler.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/crypto_module.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cert/nss_cert_database.h View 2 chunks +2 lines, -5 lines 0 comments Download
M net/cert/nss_cert_database.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/cert/nss_cert_database_chromeos.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/nss_cert_database_chromeos.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/cert/nss_cert_database_chromeos_unittest.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M net/cert/nss_profile_filter_chromeos.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/nss_profile_filter_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
mattm
The CQ bit was checked by mattm@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-25 02:33:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715063002/20001
3 years, 10 months ago (2017-02-25 02:33:53 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-25 03:26:19 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 03:26:19 UTC) #4
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698