Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: ios/web_view/internal/web_view_web_client.h

Issue 2715043002: Replace prefix of ios/web_view C++ classes. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/web_view_web_client.h
diff --git a/ios/web_view/internal/criwv_web_client.h b/ios/web_view/internal/web_view_web_client.h
similarity index 62%
rename from ios/web_view/internal/criwv_web_client.h
rename to ios/web_view/internal/web_view_web_client.h
index a6960a9473ddbb23696c438a561d57855805b11c..d83a40cb8818c3907fe1aacc94fe4b1316f603ac 100644
--- a/ios/web_view/internal/criwv_web_client.h
+++ b/ios/web_view/internal/web_view_web_client.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_CLIENT_H_
-#define IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_CLIENT_H_
+#ifndef IOS_WEB_VIEW_INTERNAL_WEB_VIEW_WEB_CLIENT_H_
+#define IOS_WEB_VIEW_INTERNAL_WEB_VIEW_WEB_CLIENT_H_
#include <memory>
#include "base/compiler_specific.h"
@@ -12,15 +12,15 @@
@protocol CWVDelegate;
namespace ios_web_view {
-class CRIWVBrowserState;
-class CRIWVWebMainParts;
+class WebViewBrowserState;
+class WebViewWebMainParts;
// CWV-specific implementation of WebClient. Delegates some functionality to
Eugene But (OOO till 7-30) 2017/02/25 01:29:28 s/CWV-specific/WebView
michaeldo 2017/02/25 07:41:12 Done.
// CWVDelegate.
Eugene But (OOO till 7-30) 2017/02/25 01:29:28 I think we can stop mentioning CWVDelegate
michaeldo 2017/02/25 07:41:12 Done.
-class CRIWVWebClient : public web::WebClient {
+class WebViewWebClient : public web::WebClient {
public:
- explicit CRIWVWebClient(id<CWVDelegate> delegate);
- ~CRIWVWebClient() override;
+ explicit WebViewWebClient(id<CWVDelegate> delegate);
+ ~WebViewWebClient() override;
// WebClient implementation.
web::WebMainParts* CreateWebMainParts() override;
@@ -28,20 +28,20 @@ class CRIWVWebClient : public web::WebClient {
std::string GetUserAgent(bool desktop_user_agent) const override;
// Normal browser state associated with the receiver.
- CRIWVBrowserState* browser_state() const;
+ WebViewBrowserState* browser_state() const;
// Off the record browser state associated with the receiver.
- CRIWVBrowserState* off_the_record_browser_state() const;
+ WebViewBrowserState* off_the_record_browser_state() const;
private:
// This object's delegate.
__weak id<CWVDelegate> delegate_;
// The WebMainParts created by |CreateWebMainParts()|.
- CRIWVWebMainParts* web_main_parts_;
+ WebViewWebMainParts* web_main_parts_;
Eugene But (OOO till 7-30) 2017/02/25 01:29:28 Should this be unique_ptr? No need to make a chang
michaeldo 2017/02/25 07:41:12 Acknowledged.
- DISALLOW_COPY_AND_ASSIGN(CRIWVWebClient);
+ DISALLOW_COPY_AND_ASSIGN(WebViewWebClient);
};
} // namespace ios_web_view
-#endif // IOS_WEB_VIEW_INTERNAL_CRIWV_WEB_CLIENT_H_
+#endif // IOS_WEB_VIEW_INTERNAL_WEB_VIEW_WEB_CLIENT_H_

Powered by Google App Engine
This is Rietveld 408576698