[Payments] Put Web Payments feature on desktop behind flag

[Payments] Put Web Payments feature on desktop behind flag

--enable-features=WebPayments

This is in addition to --enable-experimental-web-features

BUG=696032
TEST=builds, all tests

Review-Url: https://codereview.chromium.org/2715013002
Cr-Commit-Position: refs/heads/master@{#453575}
Committed: https://chromium.googlesource.com/chromium/src/+/42a50cb83ebc41b44033d1a77ecd3e719981b29d

[Mathieu, 2017-02-24 21:45:51]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 21:46:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 22:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:26:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mathieu, 2017-02-26 20:51:38]

Description was changed from

==========
[Payments] Put Web Payments feature on desktop behind flag

--enable-features=WebPayments

BUG=696032
TEST=builds, all tests
==========

to

==========
[Payments] Put Web Payments feature on desktop behind flag

--enable-features=WebPayments

This is in addition to --enable-experimental-web-features

BUG=696032
TEST=builds, all tests
==========

[Mathieu, 2017-02-26 20:51:38]

mathp@chromium.org changed reviewers:
+ rouslan@chromium.org

[Mathieu, 2017-02-26 20:51:46]

Patchset #1 (id:1) has been deleted

[Mathieu, 2017-02-26 20:51:52]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 20:52:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 21:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 21:24:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-02-26 22:23:38]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 22:23:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-02-26 22:24:00]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-26 23:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 23:17:02]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-02-27 15:32:14]

PTAL, let me know if this is what you had in mind!

[please use gerrit instead, 2017-02-27 15:56:17]

https://codereview.chromium.org/2715013002/diff/40001/content/child/runtime_f...
File content/child/runtime_features.cc (right):

https://codereview.chromium.org/2715013002/diff/40001/content/child/runtime_f...
content/child/runtime_features.cc:322: #endif
I don't think this change is necessary. It's hard to tell if it will have any
side effects. Your CL should still work without it. Would you mind not touching
this particular file?

[Mathieu, 2017-02-27 18:05:45]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[Mathieu, 2017-02-27 18:05:52]

Thanks, PTAL!

https://codereview.chromium.org/2715013002/diff/40001/content/child/runtime_f...
File content/child/runtime_features.cc (right):

https://codereview.chromium.org/2715013002/diff/40001/content/child/runtime_f...
content/child/runtime_features.cc:322: #endif
On 2017/02/27 15:56:17, rouslan wrote:
> I don't think this change is necessary. It's hard to tell if it will have any
> side effects. Your CL should still work without it. Would you mind not
touching
> this particular file?

Unh. You're right. This is mysterious to me :)

[commit-bot: I haz the power, 2017-02-27 18:06:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-02-27 18:26:17]

lgtm

[Mathieu, 2017-02-27 18:43:48]

mathp@chromium.org changed reviewers:
+ avi@chromium.org, rkaplow@chromium.org

[Mathieu, 2017-02-27 18:43:49]

avi@chromium.org: Please review changes in content/

rkaplow: histograms.xml

Thanks!

[commit-bot: I haz the power, 2017-02-27 19:28:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 19:28:26]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-02-28 02:28:45]

lgtm

[Avi (use Gerrit), 2017-02-28 02:38:29]

lgtm

stamp

[Mathieu, 2017-02-28 12:18:36]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-02-28 12:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 12:24:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488284316104870,
"parent_rev": "78c60265e580b80470359beeede8e05dd908852d", "commit_rev":
"42a50cb83ebc41b44033d1a77ecd3e719981b29d"}

[commit-bot: I haz the power, 2017-02-28 12:25:25]

Description was changed from

==========
[Payments] Put Web Payments feature on desktop behind flag

--enable-features=WebPayments

This is in addition to --enable-experimental-web-features

BUG=696032
TEST=builds, all tests
==========

to

==========
[Payments] Put Web Payments feature on desktop behind flag

--enable-features=WebPayments

This is in addition to --enable-experimental-web-features

BUG=696032
TEST=builds, all tests

Review-Url: https://codereview.chromium.org/2715013002
Cr-Commit-Position: refs/heads/master@{#453575}
Committed:
https://chromium.googlesource.com/chromium/src/+/42a50cb83ebc41b44033d1a77ecd...
==========

[commit-bot: I haz the power, 2017-02-28 12:25:26]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/42a50cb83ebc41b44033d1a77ecd...