Chromium Code Reviews
Help | Chromium Project | Sign in
(15)

Issue 2714963002: Remove code duplication in CreateWithSharedMemory.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 weeks, 1 day ago by bcwhite
Modified:
6 days ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code duplication in CreateWithSharedMemory. BUG=n/a

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Messages

Total messages: 10 (9 generated)
Ilya Sherman
2 weeks, 5 days ago (2017-03-06 19:03:20 UTC) #6
https://codereview.chromium.org/2714963002/diff/1/base/metrics/persistent_his...
File base/metrics/persistent_histogram_allocator.cc (right):

https://codereview.chromium.org/2714963002/diff/1/base/metrics/persistent_his...
base/metrics/persistent_histogram_allocator.cc:788: void
GlobalHistogramAllocator::CreateWithSharedMemory(
If you really want to keep this method around, could you please move it to an
anonymous namespace in this file?  It doesn't seem like it needs to be part of
the API for this class anymore.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62