Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2714963002: Remove code duplication in CreateWithSharedMemory.

Created:
3 years, 10 months ago by bcwhite
Modified:
3 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code duplication in CreateWithSharedMemory. BUG=n/a

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M base/metrics/persistent_histogram_allocator.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (9 generated)
Ilya Sherman
3 years, 9 months ago (2017-03-06 19:03:20 UTC) #6 
https://codereview.chromium.org/2714963002/diff/1/base/metrics/persistent_his...
File base/metrics/persistent_histogram_allocator.cc (right):

https://codereview.chromium.org/2714963002/diff/1/base/metrics/persistent_his...
base/metrics/persistent_histogram_allocator.cc:788: void
GlobalHistogramAllocator::CreateWithSharedMemory(
If you really want to keep this method around, could you please move it to an
anonymous namespace in this file?  It doesn't seem like it needs to be part of
the API for this class anymore.

Powered by Google App Engine
This is Rietveld 408576698