Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2714883002: MD Settings: About page, show error messages with <br> and <pre> tags. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, stevenjb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About page, show error messages with <br> and <pre> tags. BUG=689715 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2714883002 Cr-Commit-Position: refs/heads/master@{#452894} Committed: https://chromium.googlesource.com/chromium/src/+/7cafb071c30fe11e98598cbd1060165a8f4f22af

Patch Set 1 #

Patch Set 2 : Nit. #

Patch Set 3 : Resolved conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/test/data/webui/settings/about_page_tests.js View 1 2 3 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
dpapad
Screenshot at http://imgur.com/a/cYM8C.
3 years, 10 months ago (2017-02-24 00:10:37 UTC) #5
Dan Beam
lgtm
3 years, 10 months ago (2017-02-24 00:15:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714883002/20001
3 years, 10 months ago (2017-02-24 00:29:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/159370) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-24 00:31:39 UTC) #10
dpapad
Resolved conflicts with ToT, PTAL.
3 years, 10 months ago (2017-02-24 01:21:02 UTC) #11
Dan Beam
still lgtm
3 years, 10 months ago (2017-02-24 02:17:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714883002/40001
3 years, 10 months ago (2017-02-24 02:19:03 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/238647)
3 years, 10 months ago (2017-02-24 03:13:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714883002/40001
3 years, 10 months ago (2017-02-24 18:15:48 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 19:11:18 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7cafb071c30fe11e98598cbd1060...

Powered by Google App Engine
This is Rietveld 408576698