Fix 2 issues that were hitting dchecks when enabling ModuleDatabase

Fix 2 issues that were hitting dchecks when enabling ModuleDatabase

First, check for kInvalidIndex after calling FindLoadAdddressIndexById()
in RemoveLoadAddressById().

Second, the ModuleEventSinkPtr was used on the IO thread but was bound
on the main thread. Rebind the pointer to the IO thread.

BUG=662084
Review-Url: https://codereview.chromium.org/2714873002
Cr-Commit-Position: refs/heads/master@{#453676}
Committed: https://chromium.googlesource.com/chromium/src/+/013446f84772859431ec8cb33158cd1805a888f8

[Patrick Monette, 2017-02-23 23:49:03]

Description was changed from

==========
Remove 2 dcheck hits when enabling ModuleDatabase.

First, check for kInvalidIndex after calling FindLoadAdddressIndexById()
in RemoveLoadAddressById().

Second, the ModuleEventSinkPtr was used on the IO thread but was bound
on the main thread. Rebind the pointer to the IO thread.
==========

to

==========
Fix 2 issues that were hitting dchecks when enabling ModuleDatabase

First, check for kInvalidIndex after calling FindLoadAdddressIndexById()
in RemoveLoadAddressById().

Second, the ModuleEventSinkPtr was used on the IO thread but was bound
on the main thread. Rebind the pointer to the IO thread.
==========

[Patrick Monette, 2017-02-23 23:53:27]

pmonette@chromium.org changed reviewers:
+ thakis@chromium.org

[Patrick Monette, 2017-02-23 23:53:27]

Hey Nico, PTAL

[Patrick Monette, 2017-02-28 18:35:27]

Friendly ping

[Nico, 2017-02-28 18:40:03]

Whoops missed this, sorry.

lgtm, sounds like this is already covered by tests.

Is there some tracking bug for enabling ModuleDatabase? If yes, add to BUG=
line. If not, there probably should one to track all the related things.

[Patrick Monette, 2017-02-28 19:04:43]

Description was changed from

==========
Fix 2 issues that were hitting dchecks when enabling ModuleDatabase

First, check for kInvalidIndex after calling FindLoadAdddressIndexById()
in RemoveLoadAddressById().

Second, the ModuleEventSinkPtr was used on the IO thread but was bound
on the main thread. Rebind the pointer to the IO thread.
==========

to

==========
Fix 2 issues that were hitting dchecks when enabling ModuleDatabase

First, check for kInvalidIndex after calling FindLoadAdddressIndexById()
in RemoveLoadAddressById().

Second, the ModuleEventSinkPtr was used on the IO thread but was bound
on the main thread. Rebind the pointer to the IO thread.

BUG=662084
==========

[Patrick Monette, 2017-02-28 19:05:24]

Thanks! Added a reference to the bug.

[Patrick Monette, 2017-02-28 19:05:27]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2017-02-28 19:06:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 19:50:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488308727135440, "parent_rev":
"0ca137746a3a554d63902a61a497b0fb72a038f0", "commit_rev":
"013446f84772859431ec8cb33158cd1805a888f8"}

[commit-bot: I haz the power, 2017-02-28 19:51:10]

Description was changed from

==========
Fix 2 issues that were hitting dchecks when enabling ModuleDatabase

First, check for kInvalidIndex after calling FindLoadAdddressIndexById()
in RemoveLoadAddressById().

Second, the ModuleEventSinkPtr was used on the IO thread but was bound
on the main thread. Rebind the pointer to the IO thread.

BUG=662084
==========

to

==========
Fix 2 issues that were hitting dchecks when enabling ModuleDatabase

First, check for kInvalidIndex after calling FindLoadAdddressIndexById()
in RemoveLoadAddressById().

Second, the ModuleEventSinkPtr was used on the IO thread but was bound
on the main thread. Rebind the pointer to the IO thread.

BUG=662084

Review-Url: https://codereview.chromium.org/2714873002
Cr-Commit-Position: refs/heads/master@{#453676}
Committed:
https://chromium.googlesource.com/chromium/src/+/013446f84772859431ec8cb33158...
==========

[commit-bot: I haz the power, 2017-02-28 19:51:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/013446f84772859431ec8cb33158...