Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 2714863003: Replace remaining references to imported/wpt with external/wpt (Closed)

Created:
3 years, 10 months ago by foolip
Modified:
3 years, 10 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace remaining references to imported/wpt with external/wpt The changes in testharnessreport.js are needed when testing locally using the file protocol. When running wptserve, the code behind `location.hostname == 'web-platform.test'` checks are what makes it work. BUG=678788 R=qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2714863003 Cr-Commit-Position: refs/heads/master@{#452856} Committed: https://chromium.googlesource.com/chromium/src/+/c0828d6983df4be0c9205e65f70574d7f2f9b3e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/resources/testharnessreport.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
foolip
3 years, 10 months ago (2017-02-24 08:47:39 UTC) #1
foolip
PTAL. The linux_chromium_rel_ng failure is unrelated.
3 years, 10 months ago (2017-02-24 11:01:39 UTC) #6
qyearsley
lgtm
3 years, 10 months ago (2017-02-24 16:20:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714863003/1
3 years, 10 months ago (2017-02-24 16:23:09 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 17:26:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0828d6983df4be0c9205e65f705...

Powered by Google App Engine
This is Rietveld 408576698