Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2714853004: Remove non-MD code from overflow button and bubble (Closed)

Created:
3 years, 10 months ago by mohsen
Modified:
3 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-MD code from overflow button and bubble BUG=687799 TEST=none Review-Url: https://codereview.chromium.org/2714853004 Cr-Commit-Position: refs/heads/master@{#453655} Committed: https://chromium.googlesource.com/chromium/src/+/4116d23962b4b90c6aebd76a7f9b2521441f3741

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Messages

Total messages: 26 (18 generated)
mohsen
Please take a look...
3 years, 10 months ago (2017-02-24 19:47:33 UTC) #4
oshima
lgtm
3 years, 9 months ago (2017-02-28 02:03:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714853004/1
3 years, 9 months ago (2017-02-28 16:43:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/161667) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-02-28 16:45:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714853004/20001
3 years, 9 months ago (2017-02-28 17:41:38 UTC) #18
commit-bot: I haz the power
Failed to apply patch for ash/resources/ash_resources.grd: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-02-28 17:47:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714853004/40001
3 years, 9 months ago (2017-02-28 18:34:32 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 19:07:24 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4116d23962b4b90c6aebd76a7f9b...

Powered by Google App Engine
This is Rietveld 408576698