Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_popup_controller.h

Issue 2714813002: [iOS] Add Request Mobile Site cell to tools menu (Closed)
Patch Set: Kurt's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_popup_controller.h
diff --git a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.h b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.h
index a5d820fb5f0b1e1a4efb051b9e43e90c2cd3ab2f..7590fdd9a4601c0b32c711270a63370db0154673 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.h
+++ b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.h
@@ -21,6 +21,11 @@ extern NSString* const kToolsMenuTableViewId;
@property(nonatomic, assign) BOOL isCurrentPageBookmarked;
+// The user agent type used to load the current page, which also decides the
+// visibility and enability of "Request Desktop Site" and "Request Mobile Site"
+// cells in the tools popup menu.
+@property(nonatomic, assign) BOOL userAgentType;
+
// Initializes the popup with the given |context|, a set of information used to
// determine the appearance of the menu and the entries displayed.
- (instancetype)initWithContext:(ToolsMenuContext*)context;
@@ -28,6 +33,9 @@ extern NSString* const kToolsMenuTableViewId;
// Called when the current tab loading state changes.
- (void)setIsTabLoading:(BOOL)isTabLoading;
+// Called when the current tab user agent type changes.
+- (void)setUserAgentType:(web::UserAgentType)type;
kkhorimoto 2017/02/27 23:44:24 This isn't necessary since it's created by your pr
liaoyuke 2017/02/28 02:01:01 Done.
+
// TODO(stuartmorgan): Should the set of options that are passed in to the
// constructor just have the ability to specify whether commands should be
// enabled or disabled rather than having these individual setters? b/6048639
@@ -41,9 +49,6 @@ extern NSString* const kToolsMenuTableViewId;
// Informs tools popup menu whether the switch to reader mode is possible.
- (void)setCanUseReaderMode:(BOOL)enabled;
-// Informs tools popup menu whether "Request Desktop Site" can be enabled.
-- (void)setCanUseDesktopUserAgent:(BOOL)value;
-
@end
#endif // IOS_CHROME_BROWSER_UI_TOOLS_MENU_TOOLS_POPUP_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698