Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Issue 2714813002: [iOS] Add Request Mobile Site cell to tools menu (Closed)
Patch Set: Kurt's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
diff --git a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
index d549374658de8f28ea2bed01ec8348489922d849..2999e9f8d04ef55363a80f05f48aaed46716c6db 100644
--- a/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
+++ b/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
@@ -41,6 +41,7 @@ @interface ToolsPopupController ()<ToolsPopupTableDelegate> {
@implementation ToolsPopupController
@synthesize isCurrentPageBookmarked = _isCurrentPageBookmarked;
+@synthesize userAgentType = _userAgentType;
- (instancetype)initWithContext:(ToolsMenuContext*)context {
DCHECK(context.displayView);
@@ -131,13 +132,13 @@ - (void)setIsCurrentPageBookmarked:(BOOL)value {
[_toolsMenuViewController setIsCurrentPageBookmarked:value];
}
-// Informs tools popup menu whether the switch to reader mode is possible.
-- (void)setCanUseReaderMode:(BOOL)enabled {
- [_toolsMenuViewController setCanUseReaderMode:enabled];
+- (void)setUserAgentType:(web::UserAgentType)type {
+ _userAgentType = type;
+ [_toolsMenuViewController setUserAgentType:type];
}
-- (void)setCanUseDesktopUserAgent:(BOOL)enabled {
- [_toolsMenuViewController setCanUseDesktopUserAgent:enabled];
+- (void)setCanUseReaderMode:(BOOL)enabled {
+ [_toolsMenuViewController setCanUseReaderMode:enabled];
}
- (void)setCanShowFindBar:(BOOL)enabled {
@@ -193,6 +194,9 @@ - (void)commandWasSelected:(int)commandID {
case IDC_REQUEST_DESKTOP_SITE:
base::RecordAction(UserMetricsAction("MobileMenuRequestDesktopSite"));
break;
+ case IDC_REQUEST_MOBILE_SITE:
+ base::RecordAction(UserMetricsAction("MobileMenuRequestMobileSite"));
+ break;
case IDC_READER_MODE:
base::RecordAction(UserMetricsAction("MobileMenuRequestReaderMode"));
break;

Powered by Google App Engine
This is Rietveld 408576698