Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2714773002:
Disable TranslateManagerRenderViewHostTest.NormalTranslate with PlzNavigate. (Closed)
DescriptionDisable TranslateManagerRenderViewHostTest.NormalTranslate with PlzNavigate.
BUG=510836
Review-Url: https://codereview.chromium.org/2714773002
Cr-Commit-Position: refs/heads/master@{#452867}
Committed: https://chromium.googlesource.com/chromium/src/+/d3dadb8ec016946e09e5e54c5d6a6f77c2ada80c
Patch Set 1 : with PlzNavigate on #Patch Set 2 : undo PlzNavigate #Patch Set 3 : just disable #Messages
Total messages: 24 (17 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
The CQ bit was unchecked by jam@chromium.org
Description was changed from ========== Fix TranslateManagerRenderViewHostTest.NormalTranslate with PlzNavigate. The unittest wasn't waiting enough with the different timing of PlzNavigate when it simulates reloads. BUG= ========== to ========== Fix TranslateManagerRenderViewHostTest.NormalTranslate with PlzNavigate. The unittest wasn't waiting enough with the different timing of PlzNavigate when it simulates reloads. BUG=510836 ==========
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jam@chromium.org changed reviewers: + groby@chromium.org
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix TranslateManagerRenderViewHostTest.NormalTranslate with PlzNavigate. The unittest wasn't waiting enough with the different timing of PlzNavigate when it simulates reloads. BUG=510836 ========== to ========== Disable TranslateManagerRenderViewHostTest.NormalTranslate with PlzNavigate. BUG=510836 ==========
groby@google.com changed reviewers: + groby@google.com
The CQ bit was checked by groby@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by groby@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487958780424930,
"parent_rev": "25b0ca399c5d7f2030d0069dad33acdae4a5a9fc", "commit_rev":
"d3dadb8ec016946e09e5e54c5d6a6f77c2ada80c"}
Message was sent while issue was closed.
Description was changed from ========== Disable TranslateManagerRenderViewHostTest.NormalTranslate with PlzNavigate. BUG=510836 ========== to ========== Disable TranslateManagerRenderViewHostTest.NormalTranslate with PlzNavigate. BUG=510836 Review-Url: https://codereview.chromium.org/2714773002 Cr-Commit-Position: refs/heads/master@{#452867} Committed: https://chromium.googlesource.com/chromium/src/+/d3dadb8ec016946e09e5e54c5d6a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d3dadb8ec016946e09e5e54c5d6a... |
