Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2714763003: Revert of [tab_grid] Hack-in border for active tab. (Closed)

Created:
3 years, 9 months ago by lody
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, lpromero+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tab_grid] Hack-in border for active tab. (patchset #5 id:80001 of https://codereview.chromium.org/2709563002/ ) Reason for revert: Test "testLaunchAndTappingCell" in ios_showcase_egtests is broken by this CL. https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/24682 Original issue's description: > [tab_grid] Hack-in border for active tab. > > Screenshot: > https://drive.google.com/open?id=0BwS6YyQeisH5WmpVS0tHcl9tN0E > > BUG=686770 > > Review-Url: https://codereview.chromium.org/2709563002 > Cr-Commit-Position: refs/heads/master@{#452796} > Committed: https://chromium.googlesource.com/chromium/src/+/a10c1ff3e00da36f1532264aa1866433aedaaae5 TBR=sczs@chromium.org,jif@chromium.org,marq@chromium.org,lpromero@chromium.org,edchin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686770 Review-Url: https://codereview.chromium.org/2714763003 Cr-Commit-Position: refs/heads/master@{#452813} Committed: https://chromium.googlesource.com/chromium/src/+/08c967e83d04e01d125b34698baa891f9882be03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -55 lines) Patch
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.h View 1 chunk +5 lines, -6 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.mm View 1 chunk +24 lines, -8 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm View 6 chunks +8 lines, -30 lines 0 comments Download
M ios/showcase/tab_grid/sc_tab_grid_coordinator.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
lody
Created Revert of [tab_grid] Hack-in border for active tab.
3 years, 9 months ago (2017-02-24 13:42:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714763003/1
3 years, 9 months ago (2017-02-24 14:07:36 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-02-24 14:07:37 UTC) #5
jif
lgtm
3 years, 9 months ago (2017-02-24 14:07:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714763003/1
3 years, 9 months ago (2017-02-24 14:08:37 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 14:09:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08c967e83d04e01d125b34698baa...

Powered by Google App Engine
This is Rietveld 408576698