Improve appearance of focus rings at fractional scales.

Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

TBR=derat@chromium.org
BUG=695540
Review-Url: https://codereview.chromium.org/2714753002
Cr-Commit-Position: refs/heads/master@{#453289}
Committed: https://chromium.googlesource.com/chromium/src/+/046559ce9c88712b6226947bc4b2d186bd3a1d12

[Evan Stade, 2017-02-23 18:54:27]

Description was changed from

==========
Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders.

TreeView is also updated to use a blue outline instead of a dashed focus
rect. This makes it a closer match to the vast majority of focus
indicators in Chrome.

BUG=695540
==========

to

==========
Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

BUG=695540
==========

[Evan Stade, 2017-02-23 18:55:03]

estade@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2017-02-23 19:15:13]

lgtm with commented code fixed

https://codereview.chromium.org/2714753002/diff/20001/ui/views/controls/tree/...
File ui/views/controls/tree/tree_view.cc (right):

https://codereview.chromium.org/2714753002/diff/20001/ui/views/controls/tree/...
ui/views/controls/tree/tree_view.cc:1061: if
(/*!ui::MaterialDesignController::IsSecondaryUiMaterial() ||*/
Fix this

[Evan Stade, 2017-02-23 20:07:29]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2017-02-23 20:07:30]

+sadrul for OWNERS of ash and ui

(will fix msw's comment shortly)

https://codereview.chromium.org/2714753002/diff/20001/ui/views/controls/tree/...
File ui/views/controls/tree/tree_view.cc (right):

https://codereview.chromium.org/2714753002/diff/20001/ui/views/controls/tree/...
ui/views/controls/tree/tree_view.cc:1061: if
(/*!ui::MaterialDesignController::IsSecondaryUiMaterial() ||*/
On 2017/02/23 19:15:13, msw wrote:
> Fix this

my bad, this is residue from the CL I split off.

[Evan Stade, 2017-02-23 21:03:42]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 21:04:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-23 21:14:31]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 21:14:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:17:52]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-02-25 01:29:21]

lgtm

[Evan Stade, 2017-02-25 05:54:33]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-25 05:54:34]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2714753002/#ps40001
(title: "remove errant change")

[commit-bot: I haz the power, 2017-02-25 05:54:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 06:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 06:00:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2017-02-27 15:53:52]

Description was changed from

==========
Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

BUG=695540
==========

to

==========
Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

TBR=tdanderson@chromium.org
BUG=695540
==========

[Evan Stade, 2017-02-27 15:53:52]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[Evan Stade, 2017-02-27 15:54:09]

TBR tdanderson for ash/common change

[Evan Stade, 2017-02-27 15:55:08]

Description was changed from

==========
Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

TBR=tdanderson@chromium.org
BUG=695540
==========

to

==========
Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

TBR=derat@chromium.org
BUG=695540
==========

[Evan Stade, 2017-02-27 15:55:09]

estade@chromium.org changed reviewers:
+ derat@chromium.org
- tdanderson@chromium.org

[Evan Stade, 2017-02-27 15:55:24]

whoops, -tdanderson +derat TBR for ash/

[Evan Stade, 2017-02-27 15:55:30]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-02-27 15:56:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2017-02-27 16:47:50]

lgtm

[commit-bot: I haz the power, 2017-02-27 16:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:55:20]

Failed to apply patch for ash/common/ash_constants.cc:
While running git apply --index -p1;
  error: patch failed: ash/common/ash_constants.cc:17
  error: ash/common/ash_constants.cc: patch does not apply

Patch:       ash/common/ash_constants.cc
Index: ash/common/ash_constants.cc
diff --git a/ash/common/ash_constants.cc b/ash/common/ash_constants.cc
index
e8b143456a7e09a4016a08780e0dc038db8169f2..2de9702c9c03eb0965f9b0a1ead455c5084d59ad
100644
--- a/ash/common/ash_constants.cc
+++ b/ash/common/ash_constants.cc
@@ -17,6 +17,6 @@ const int kResizeInsideBoundsSize = 1;
 const SkColor kChromeOsBootColor = SkColorSetRGB(0xfe, 0xfe, 0xfe);
 
 const SkColor kFocusBorderColor = SkColorSetA(gfx::kGoogleBlue500, 0x99);
-const float kFocusBorderThickness = 2.f;
+const int kFocusBorderThickness = 2;
 
 }  // namespace ash

[Evan Stade, 2017-02-27 18:02:30]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-27 18:02:31]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
derat@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2714753002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-27 18:03:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:19:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488218550910610,
"parent_rev": "10b633b595d245bf4cfb534a38468e40da4fa448", "commit_rev":
"046559ce9c88712b6226947bc4b2d186bd3a1d12"}

[commit-bot: I haz the power, 2017-02-27 19:20:14]

Description was changed from

==========
Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

TBR=derat@chromium.org
BUG=695540
==========

to

==========
Improve appearance of focus rings at fractional scales.

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

TBR=derat@chromium.org
BUG=695540

Review-Url: https://codereview.chromium.org/2714753002
Cr-Commit-Position: refs/heads/master@{#453289}
Committed:
https://chromium.googlesource.com/chromium/src/+/046559ce9c88712b6226947bc4b2...
==========

[commit-bot: I haz the power, 2017-02-27 19:20:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/046559ce9c88712b6226947bc4b2...