Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2714703002: Avoid needless InstanceCounter.h inclusion. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
Yuta Kitamura
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid needless InstanceCounter.h inclusion. Only needed if RefCounted<> is compiled specially. R= BUG= Review-Url: https://codereview.chromium.org/2714703002 Cr-Commit-Position: refs/heads/master@{#452453} Committed: https://chromium.googlesource.com/chromium/src/+/939433df22bf285396491e31f0d84ad8da5354df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/wtf/RefCounted.h View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look. it pulls in TypeTraits.h et al, so better left out.
3 years, 10 months ago (2017-02-23 08:36:28 UTC) #4
Yuta Kitamura
lgtm
3 years, 10 months ago (2017-02-23 08:51:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714703002/1
3 years, 10 months ago (2017-02-23 10:56:35 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 11:01:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/939433df22bf285396491e31f0d8...

Powered by Google App Engine
This is Rietveld 408576698