Tidy up event-/syncbase registration in SVGSMILElement

Tidy up event-/syncbase registration in SVGSMILElement

Move code for connect/disconnecting from event- and syncbase into the
Condition innerclass to improve readability.
Also make Condition::m_baseID and m_name be AtomicStrings (to avoid
casting and hashing all over the place), convert loops to range-syntax
and use references where it makes sense in related code-paths.

BUG=641437
Review-Url: https://codereview.chromium.org/2714643007
Cr-Commit-Position: refs/heads/master@{#452857}
Committed: https://chromium.googlesource.com/chromium/src/+/08955414c3de2232b6d3f69bb0ceb5227af35f86

[fs, 2017-02-24 11:48:05]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 11:48:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 12:19:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 12:19:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fs, 2017-02-24 12:30:50]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 12:31:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-02-24 13:23:46]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[fs, 2017-02-24 13:23:47]

The indentation made me do it...

[commit-bot: I haz the power, 2017-02-24 14:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 14:08:08]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2017-02-24 16:08:22]

On 2017/02/24 13:23:47, fs wrote:
> The indentation made me do it...

Good to someone as bothered by bad looking code as I am.

lgtm

[fs, 2017-02-24 17:25:10]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-02-24 17:25:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 17:29:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487957110743230,
"parent_rev": "c0828d6983df4be0c9205e65f70574d7f2f9b3e8", "commit_rev":
"08955414c3de2232b6d3f69bb0ceb5227af35f86"}

[commit-bot: I haz the power, 2017-02-24 17:30:09]

Description was changed from

==========
Tidy up event-/syncbase registration in SVGSMILElement

Move code for connect/disconnecting from event- and syncbase into the
Condition innerclass to improve readability.
Also make Condition::m_baseID and m_name be AtomicStrings (to avoid
casting and hashing all over the place), convert loops to range-syntax
and use references where it makes sense in related code-paths.

BUG=641437
==========

to

==========
Tidy up event-/syncbase registration in SVGSMILElement

Move code for connect/disconnecting from event- and syncbase into the
Condition innerclass to improve readability.
Also make Condition::m_baseID and m_name be AtomicStrings (to avoid
casting and hashing all over the place), convert loops to range-syntax
and use references where it makes sense in related code-paths.

BUG=641437

Review-Url: https://codereview.chromium.org/2714643007
Cr-Commit-Position: refs/heads/master@{#452857}
Committed:
https://chromium.googlesource.com/chromium/src/+/08955414c3de2232b6d3f69bb0ce...
==========

[commit-bot: I haz the power, 2017-02-24 17:30:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/08955414c3de2232b6d3f69bb0ce...