Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2714643005: GN docs: update the example of declare_args(). (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN docs: update the example of declare_args(). BUG=None Review-Url: https://codereview.chromium.org/2714643005 Cr-Commit-Position: refs/heads/master@{#452640} Committed: https://chromium.googlesource.com/chromium/src/+/b7fb5fc4195bd36c81225691ae236363c1d05873

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/gn/docs/reference.md View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/functions.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
yzshen1
Hi, Brett. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-23 17:19:15 UTC) #2
yzshen1
Hi, Brett. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-23 17:19:16 UTC) #3
brettw
https://codereview.chromium.org/2714643005/diff/1/tools/gn/docs/reference.md File tools/gn/docs/reference.md (right): https://codereview.chromium.org/2714643005/diff/1/tools/gn/docs/reference.md#newcode1685 tools/gn/docs/reference.md:1685: gn --args="enable_doom_melon=true enable_teleporter=true" This is generated from the built-in ...
3 years, 10 months ago (2017-02-23 17:37:43 UTC) #4
yzshen1
https://codereview.chromium.org/2714643005/diff/1/tools/gn/docs/reference.md File tools/gn/docs/reference.md (right): https://codereview.chromium.org/2714643005/diff/1/tools/gn/docs/reference.md#newcode1685 tools/gn/docs/reference.md:1685: gn --args="enable_doom_melon=true enable_teleporter=true" On 2017/02/23 17:37:43, brettw (plz ping ...
3 years, 10 months ago (2017-02-23 17:54:10 UTC) #5
brettw
lgtm
3 years, 10 months ago (2017-02-23 21:06:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714643005/20001
3 years, 10 months ago (2017-02-23 21:06:50 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 21:42:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b7fb5fc4195bd36c81225691ae23...

Powered by Google App Engine
This is Rietveld 408576698