Chromium Code Reviews| Index: chrome/browser/android/webapk/webapk_info.cc |
| diff --git a/chrome/browser/android/webapk/webapk_info.cc b/chrome/browser/android/webapk/webapk_info.cc |
| index d97a469a708e401abe88522c921691abcd31ae8b..a17c64880975be9030d0a356d86f482be2d50f00 100644 |
| --- a/chrome/browser/android/webapk/webapk_info.cc |
| +++ b/chrome/browser/android/webapk/webapk_info.cc |
| @@ -4,13 +4,31 @@ |
| #include "chrome/browser/android/webapk/webapk_info.h" |
|
dominickn
2017/02/27 02:27:02
#include <utility> for std::move()
gonzalon
2017/02/27 16:00:12
Done.
|
| -WebApkInfo::WebApkInfo(std::string short_name, |
| +WebApkInfo::WebApkInfo(std::string name, |
| + std::string short_name, |
| std::string package_name, |
| int shell_apk_version, |
| - int version_code) |
| - : short_name(short_name), |
| + int version_code, |
| + std::string uri, |
| + std::string scope, |
| + std::string manifest_url, |
| + std::string manifest_start_url, |
| + blink::WebDisplayMode display, |
| + blink::WebScreenOrientationLockType orientation, |
| + int64_t theme_color, |
| + int64_t background_color) |
| + : name(name), |
|
dominickn
2017/02/27 02:27:02
Every string in here should have std::move(), i.e.
gonzalon
2017/02/27 16:00:12
Done.
|
| + short_name(short_name), |
| package_name(package_name), |
| shell_apk_version(shell_apk_version), |
| - version_code(version_code) {} |
| + version_code(version_code), |
| + uri(uri), |
| + scope(scope), |
| + manifest_url(manifest_url), |
| + manifest_start_url(manifest_start_url), |
| + display(display), |
| + orientation(orientation), |
| + theme_color(theme_color), |
| + background_color(background_color) {} |
| WebApkInfo::~WebApkInfo() {} |