Adds more metadata to the about:webapks page

chrome/browser/android/webapk/webapk_info.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_info.h"

[dominickn, 2017/02/27 02:27:02]

#include <utility> for std::move()

[gonzalon, 2017/02/27 16:00:12]

Done.

 
-WebApkInfo::WebApkInfo(std::string short_name,
+WebApkInfo::WebApkInfo(std::string name,
+                       std::string short_name,
                        std::string package_name,
                        int shell_apk_version,
-                       int version_code)
-    : short_name(short_name),
+                       int version_code,
+                       std::string uri,
+                       std::string scope,
+                       std::string manifest_url,
+                       std::string manifest_start_url,
+                       blink::WebDisplayMode display,
+                       blink::WebScreenOrientationLockType orientation,
+                       int64_t theme_color,
+                       int64_t background_color)
+    : name(name),

[dominickn, 2017/02/27 02:27:02]

Every string in here should have std::move(), i.e.

name(std::move(name));

[gonzalon, 2017/02/27 16:00:12]

Done.

+      short_name(short_name),
       package_name(package_name),
       shell_apk_version(shell_apk_version),
-      version_code(version_code) {}
+      version_code(version_code),
+      uri(uri),
+      scope(scope),
+      manifest_url(manifest_url),
+      manifest_start_url(manifest_start_url),
+      display(display),
+      orientation(orientation),
+      theme_color(theme_color),
+      background_color(background_color) {}
 
 WebApkInfo::~WebApkInfo() {}