[TTS] Default-enable AMP clicks promote to new tab

[TTS] Default-enable AMP clicks promote to new tab

A previous CL added special treatment for AMP pages when they
are clicked on in the Contextual Search Overlay.  However the
functionality was behind a flag, which we never enabled.

This changes the AMP case to be behind a default-enabled flag that
will allow us to disable if needed.

BUG=645325
Review-Url: https://codereview.chromium.org/2714623002
Cr-Commit-Position: refs/heads/master@{#453291}
Committed: https://chromium.googlesource.com/chromium/src/+/13dd2cb9a8ed7bf0fc7fd88390f3467f1eada817

[Donn Denman, 2017-02-24 01:52:07]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 01:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Donn Denman, 2017-02-24 01:53:22]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2017-02-24 01:53:23]

Theresa, PTAL sometime Friday if convenient.

[commit-bot: I haz the power, 2017-02-24 02:29:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 02:29:08]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-02-24 17:22:07]

lgtm % nit

https://codereview.chromium.org/2714623002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java
(right):

https://codereview.chromium.org/2714623002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java:411:
if (ContextualSearchFieldTrial.isAmpAsSeparateTabDisabled()) return false;
nit: I think it makes more sense to keep this check in
ContextualSearchManager#onMAinFrameNavigation.

[Donn Denman, 2017-02-27 18:42:35]

Thanks Theresa.

https://codereview.chromium.org/2714623002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java
(right):

https://codereview.chromium.org/2714623002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java:411:
if (ContextualSearchFieldTrial.isAmpAsSeparateTabDisabled()) return false;
On 2017/02/24 17:22:07, Theresa wrote:
> nit: I think it makes more sense to keep this check in
> ContextualSearchManager#onMAinFrameNavigation.

Done.

[Donn Denman, 2017-02-27 18:42:41]

The CQ bit was checked by donnd@chromium.org

[Donn Denman, 2017-02-27 18:42:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2714623002/#ps20001
(title: "Addressed Theresa's comment.")

[commit-bot: I haz the power, 2017-02-27 18:43:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:24:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488220961027820,
"parent_rev": "048c85fa7f4b8251aa4af20d108a149b5e6993fc", "commit_rev":
"13dd2cb9a8ed7bf0fc7fd88390f3467f1eada817"}

[commit-bot: I haz the power, 2017-02-27 19:25:05]

Description was changed from

==========
[TTS] Default-enable AMP clicks promote to new tab

A previous CL added special treatment for AMP pages when they
are clicked on in the Contextual Search Overlay.  However the
functionality was behind a flag, which we never enabled.

This changes the AMP case to be behind a default-enabled flag that
will allow us to disable if needed.

BUG=645325
==========

to

==========
[TTS] Default-enable AMP clicks promote to new tab

A previous CL added special treatment for AMP pages when they
are clicked on in the Contextual Search Overlay.  However the
functionality was behind a flag, which we never enabled.

This changes the AMP case to be behind a default-enabled flag that
will allow us to disable if needed.

BUG=645325

Review-Url: https://codereview.chromium.org/2714623002
Cr-Commit-Position: refs/heads/master@{#453291}
Committed:
https://chromium.googlesource.com/chromium/src/+/13dd2cb9a8ed7bf0fc7fd88390f3...
==========

[commit-bot: I haz the power, 2017-02-27 19:25:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/13dd2cb9a8ed7bf0fc7fd88390f3...