Clean Obsolete HTTP Data from the Password Store

components/password_manager/core/browser/BUILD.gn

Index: components/password_manager/core/browser/BUILD.gn
diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn
index 8b4356cda8a95e92cca4890d35e3092db09afd7b..d3950b9e0e3c3fd4aec716b5c9e43f4469bcf50d 100644
--- a/components/password_manager/core/browser/BUILD.gn
+++ b/components/password_manager/core/browser/BUILD.gn
@@ -52,6 +52,10 @@ static_library("browser") {
     "form_saver.h",
     "form_saver_impl.cc",
     "form_saver_impl.h",
+    "hsts_query.cc",
+    "hsts_query.h",
+    "http_data_cleaner.cc",
+    "http_data_cleaner.h",

[jdoerrie, 2017/03/28 13:18:41]

I wasn't quite sure how to do the exclusion for IOS. I thought about

  if (is_ios) {
    sources -= [ my files ]
  }

but wasn't sure whether I also need to include #if !defined(OS_IOS) guards in
the code. How is this usually done?

[vabr (Chromium), 2017/03/28 13:39:11]

The if-clause in GN is sufficient. Once you have that, no #if !defined(OS_IOS)
are needed, because those files are no longer compiled on iOS.

     "http_password_store_migrator.cc",
     "http_password_store_migrator.h",
     "import/csv_reader.cc",
@@ -74,8 +78,6 @@ static_library("browser") {
     "login_database_win.cc",
     "login_model.cc",
     "login_model.h",
-    "obsolete_http_cleaner.cc",
-    "obsolete_http_cleaner.h",
     "password_autofill_manager.cc",
     "password_autofill_manager.h",
     "password_bubble_experiment.cc",
@@ -280,6 +282,8 @@ source_set("unit_tests") {
     "facet_manager_unittest.cc",
     "form_fetcher_impl_unittest.cc",
     "form_saver_impl_unittest.cc",
+    "hsts_query_unittest.cc",
+    "http_data_cleaner_unittest.cc",
     "http_password_store_migrator_unittest.cc",
     "import/csv_reader_unittest.cc",
     "import/password_csv_reader_unittest.cc",
@@ -288,7 +292,6 @@ source_set("unit_tests") {
     "log_router_unittest.cc",
     "login_database_unittest.cc",
     "login_model_unittest.cc",
-    "obsolete_http_cleaner_unittest.cc",
     "password_autofill_manager_unittest.cc",
     "password_bubble_experiment_unittest.cc",
     "password_form_manager_unittest.cc",