Clean Obsolete HTTP Data from the Password Store

components/password_manager/core/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/protobuf/proto_library.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
 }
 
@@ skipping 34 matching lines @@
     "export/password_exporter.h",
     "facet_manager.cc",
     "facet_manager.h",
     "facet_manager_host.h",
     "form_fetcher.h",
     "form_fetcher_impl.cc",
     "form_fetcher_impl.h",
     "form_saver.h",
     "form_saver_impl.cc",
     "form_saver_impl.h",
+    "hsts_query.cc",
+    "hsts_query.h",
+    "http_data_cleaner.cc",
+    "http_data_cleaner.h",

[jdoerrie, 2017/03/28 13:18:41]

I wasn't quite sure how to do the exclusion for IOS. I thought about

  if (is_ios) {
    sources -= [ my files ]
  }

but wasn't sure whether I also need to include #if !defined(OS_IOS) guards in
the code. How is this usually done?

[vabr (Chromium), 2017/03/28 13:39:11]

The if-clause in GN is sufficient. Once you have that, no #if !defined(OS_IOS)
are needed, because those files are no longer compiled on iOS.

     "http_password_store_migrator.cc",
     "http_password_store_migrator.h",
     "import/csv_reader.cc",
     "import/csv_reader.h",
     "import/password_csv_reader.cc",
     "import/password_csv_reader.h",
     "import/password_importer.cc",
     "import/password_importer.h",
     "keychain_migration_status_mac.h",
     "log_manager.cc",
     "log_manager.h",
     "log_receiver.h",
     "log_router.cc",
     "log_router.h",
     "login_database.cc",
     "login_database.h",
     "login_database_ios.cc",
     "login_database_mac.cc",
     "login_database_posix.cc",
     "login_database_win.cc",
     "login_model.cc",
     "login_model.h",
-    "obsolete_http_cleaner.cc",
-    "obsolete_http_cleaner.h",
     "password_autofill_manager.cc",
     "password_autofill_manager.h",
     "password_bubble_experiment.cc",
     "password_bubble_experiment.h",
     "password_form_manager.cc",
     "password_form_manager.h",
     "password_generation_manager.cc",
     "password_generation_manager.h",
     "password_manager.cc",
     "password_manager.h",
@@ skipping 184 matching lines @@
     "affiliation_utils_unittest.cc",
     "browser_save_password_progress_logger_unittest.cc",
     "credential_manager_logger_unittest.cc",
     "credential_manager_password_form_manager_unittest.cc",
     "export/csv_writer_unittest.cc",
     "export/password_csv_writer_unittest.cc",
     "export/password_exporter_unittest.cc",
     "facet_manager_unittest.cc",
     "form_fetcher_impl_unittest.cc",
     "form_saver_impl_unittest.cc",
+    "hsts_query_unittest.cc",
+    "http_data_cleaner_unittest.cc",
     "http_password_store_migrator_unittest.cc",
     "import/csv_reader_unittest.cc",
     "import/password_csv_reader_unittest.cc",
     "import/password_importer_unittest.cc",
     "log_manager_unittest.cc",
     "log_router_unittest.cc",
     "login_database_unittest.cc",
     "login_model_unittest.cc",
-    "obsolete_http_cleaner_unittest.cc",
     "password_autofill_manager_unittest.cc",
     "password_bubble_experiment_unittest.cc",
     "password_form_manager_unittest.cc",
     "password_generation_manager_unittest.cc",
     "password_manager_settings_migration_experiment_unittest.cc",
     "password_manager_unittest.cc",
     "password_manager_util_unittest.cc",
     "password_reuse_detection_manager_unittest.cc",
     "password_reuse_detector_unittest.cc",
     "password_store_default_unittest.cc",
@@ skipping 28 matching lines @@
     "//components/sync:test_support_model",
     "//components/variations",
     "//net:test_support",
     "//sql:test_support",
     "//testing/gmock",
     "//testing/gtest",
     "//ui/base",
     "//url",
   ]
 }