Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2714543003: Remove docked-mode notification (Closed)

Created:
3 years, 10 months ago by afakhry
Modified:
3 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove docked-mode notification Users found the docked mode events notifications annoying. We decided to remove them entirely. BUG=674719 TEST=updated tests to reflect new behavior. Review-Url: https://codereview.chromium.org/2714543003 Cr-Commit-Position: refs/heads/master@{#452521} Committed: https://chromium.googlesource.com/chromium/src/+/da0829e4642d9eb31f9454be3e6168cffdb4d257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -56 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +0 lines, -9 lines 0 comments Download
M ash/system/chromeos/screen_layout_observer.cc View 4 chunks +13 lines, -30 lines 0 comments Download
M ash/system/chromeos/screen_layout_observer_unittest.cc View 4 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
afakhry
Oshima-san, please take a look, thank you.
3 years, 10 months ago (2017-02-22 22:03:47 UTC) #2
oshima
LGTM
3 years, 10 months ago (2017-02-23 02:00:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714543003/1
3 years, 10 months ago (2017-02-23 16:58:53 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 17:04:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da0829e4642d9eb31f9454be3e61...

Powered by Google App Engine
This is Rietveld 408576698