Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5053)

Unified Diff: chromecast/app/BUILD.gn

Issue 2714393004: grit: qualify includes for shell_resources.h, virtual_driver_setup_resources.h, bluetooth_strings.h (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromecast/browser/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/app/BUILD.gn
diff --git a/chromecast/app/BUILD.gn b/chromecast/app/BUILD.gn
index 8de02c89df413b0c02b2e1024e420b4607d987f6..55c82872acf7249b9aac59cafb5f60295085629a 100644
--- a/chromecast/app/BUILD.gn
+++ b/chromecast/app/BUILD.gn
@@ -92,6 +92,7 @@ source_set("unittests") {
grit("resources") {
source = "//chromecast/app/resources/shell_resources.grd"
+ use_qualified_include = true
resource_ids = "//chromecast/app/resources/resource_ids"
@@ -104,6 +105,8 @@ grit("resources") {
grit("chromecast_settings") {
source = "//chromecast/app/resources/chromecast_settings.grd"
resource_ids = "//chromecast/app/resources/resource_ids"
+
+ # TODO(thakis): Consider removing this in favor of the default directory.
slan 2017/02/27 16:01:34 Are you interested in moving this for consistency'
Nico 2017/02/27 16:05:59 There's another advantage: With this output_dir, o
output_dir = "$root_gen_dir/chromecast_strings"
outputs = [
« no previous file with comments | « no previous file | chromecast/browser/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698