grit: qualify includes for shell_resources.h, virtual_driver_setup_resources.h, bluetooth_strings.h

chromecast/app/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//testing/test.gni")
 import("//tools/grit/grit_rule.gni")
 
 source_set("app") {
   sources = [
     "cast_main_delegate.cc",
@@ skipping 74 matching lines @@
     "//base/test:test_support",
     "//chromecast/base:test_support",
     "//chromecast/crash",
     "//chromecast/crash:test_support",
     "//testing/gtest",
   ]
 }
 
 grit("resources") {
   source = "//chromecast/app/resources/shell_resources.grd"
+  use_qualified_include = true
 
   resource_ids = "//chromecast/app/resources/resource_ids"
 
   outputs = [
     "grit/shell_resources.h",
     "shell_resources.pak",
   ]
 }
 
 grit("chromecast_settings") {
   source = "//chromecast/app/resources/chromecast_settings.grd"
   resource_ids = "//chromecast/app/resources/resource_ids"
+
+  # TODO(thakis): Consider removing this in favor of the default directory.

[slan, 2017/02/27 16:01:34]

Are you interested in moving this for consistency's sake, or is there another
advantage as well? If we do leave a TODO here, could we take out a bug as well?

[Nico, 2017/02/27 16:05:59]

There's another advantage: With this output_dir, once we make this target have
use_qualified_include=true too, the .h file needs to be included via #include
chromecast_strings/grit/chromecast_settings.h" which in turn requires a
+chromecast_strings entry in a DEPS file, which in return needs an LGTM from a
chromecast_strings/OWNER for the new dep -- but that file doesn't exist.

Using the default output dir nicely makes grit outputs match the existing DEPS
system.

Do you remember why this line was needed? Almost all grit() targets don't have
it.

   output_dir = "$root_gen_dir/chromecast_strings"
 
   outputs = [
     "grit/chromecast_settings.h",
     "chromecast_settings_am.pak",
     "chromecast_settings_ar.pak",
     "chromecast_settings_bg.pak",
     "chromecast_settings_bn.pak",
     "chromecast_settings_ca.pak",
     "chromecast_settings_cs.pak",
@@ skipping 40 matching lines @@
     "chromecast_settings_ta.pak",
     "chromecast_settings_te.pak",
     "chromecast_settings_th.pak",
     "chromecast_settings_tr.pak",
     "chromecast_settings_uk.pak",
     "chromecast_settings_vi.pak",
     "chromecast_settings_zh-CN.pak",
     "chromecast_settings_zh-TW.pak",
   ]
 }