fix MemoryResourceProvider context on Windows

fix MemoryResourceProvider context on Windows

On Windows, the MemoryResourceProvider.convertPath method
prefixes the path with the C: drive, but the context associated with
the MemoryResourceProvider has a drive letter based upon the underlying
current directory. Most of the time, these two drive letters are the
same, but sometimes, such as on the Windows bot, the current working
directory is on drive E:, rather than drive C:.
This causes package Uris to be mapped to drive E: rather than the
expected drive C:

This CL changes the MemoryResourceProvider constructor
to set the current working directory to C:\ when running on Windows
so that it aligns with MemoryResourceProvider.convertPath.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/4ca5ac929a3525709afe9ff02cde32f184a77a22

[danrubel, 2017-02-26 17:19:44]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-02-26 17:44:36]

Would it make more sense to make convertPath use the current drive letter?
Maybe, given that we're only talking about in-memory operations, it doesn't
matter.

If not, lgtm.

[danrubel, 2017-02-26 17:53:20]

On 2017/02/26 17:44:36, Brian Wilkerson wrote:
> Would it make more sense to make convertPath use the current drive letter?
> Maybe, given that we're only talking about in-memory operations, it doesn't
> matter.
> 
> If not, lgtm.

As you eluded to, because this is an in-memory resource provider, it does not
matter so long as the drive letter is consistent. Hard coding the drive letter
in the constructor will cause tests to fail on the Windows bots if we have
inadvertently used two different resource providers, so I lean toward doing it
this way.

[danrubel, 2017-02-26 21:30:50]

Description was changed from

==========
fix MemoryResourceProvider context on Windows

On Windows, the MemoryResourceProvider.convertPath method
prefixes the path with the C: drive, but the context associated with
the MemoryResourceProvider has a drive letter based upon the underlying
current directory. Most of the time, these two drive letters are the
same, but sometimes, such as on the Windows bot, the current working
directory is on drive E:, rather than drive C:.
This causes package Uris to be mapped to drive E: rather than the
expected drive C:

This CL changes the MemoryResourceProvider constructor
to set the current working directory to C:\ when running on Windows
so that it aligns with MemoryResourceProvider.convertPath.
==========

to

==========
fix MemoryResourceProvider context on Windows

On Windows, the MemoryResourceProvider.convertPath method
prefixes the path with the C: drive, but the context associated with
the MemoryResourceProvider has a drive letter based upon the underlying
current directory. Most of the time, these two drive letters are the
same, but sometimes, such as on the Windows bot, the current working
directory is on drive E:, rather than drive C:.
This causes package Uris to be mapped to drive E: rather than the
expected drive C:

This CL changes the MemoryResourceProvider constructor
to set the current working directory to C:\ when running on Windows
so that it aligns with MemoryResourceProvider.convertPath.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4ca5ac929a3525709afe9ff02cde32f184a77a22
==========

[danrubel, 2017-02-26 21:30:51]

Committed patchset #2 (id:20001) manually as
4ca5ac929a3525709afe9ff02cde32f184a77a22 (presubmit successful).