Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: pkg/analyzer/test/src/context/builder_test.dart

Issue 2714373002: fix MemoryResourceProvider context on Windows (Closed)
Patch Set: merge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/context/builder_test.dart
diff --git a/pkg/analyzer/test/src/context/builder_test.dart b/pkg/analyzer/test/src/context/builder_test.dart
index 83e059329844874a986cc88fb19345bfd8553651..853adbdd393b53e57b09e1d8248b7c12d7e425f8 100644
--- a/pkg/analyzer/test/src/context/builder_test.dart
+++ b/pkg/analyzer/test/src/context/builder_test.dart
@@ -722,25 +722,21 @@ linter:
AnalysisOptionsImpl expected = new AnalysisOptionsImpl();
expected.lint = true;
expected.lintRules = <Linter>[_mockLintRule];
+ String packagesFilePath =
+ resourceProvider.convertPath('/some/directory/path/.packages');
+ createFile(packagesFilePath, 'flutter:/pkg/flutter/lib/');
+ String optionsFilePath = resourceProvider
+ .convertPath('/pkg/flutter/lib/analysis_options_user.yaml');
createFile(
- resourceProvider.convertPath('/some/directory/path/.packages'),
- '''
-flutter:/pkg/flutter/lib/
-''');
- createFile(
- resourceProvider
- .convertPath('/pkg/flutter/lib/analysis_options_user.yaml'),
+ optionsFilePath,
'''
linter:
rules:
- mock_lint_rule
''');
- AnalysisOptions options = builder.getAnalysisOptions(
- resourceProvider.convertPath('/some/directory/path'));
- // TODO(danrubel) fix on Windows
- if (resourceProvider.absolutePathContext.separator != r'\') {
- _expectEqualOptions(options, expected);
- }
+ String projPath = resourceProvider.convertPath('/some/directory/path');
+ AnalysisOptions options = builder.getAnalysisOptions(projPath);
+ _expectEqualOptions(options, expected);
}
void test_getAnalysisOptions_default_noOverrides() {
« no previous file with comments | « pkg/analyzer/lib/file_system/memory_file_system.dart ('k') | pkg/analyzer/test/src/context/source_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698