Issue 2714303002: DO NOT SUBMIT: Allow SafeBrowsing in WebView for N and below

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2714303002: DO NOT SUBMIT: Allow SafeBrowsing in WebView for N and below (Closed)

Created:
3 years, 10 months ago by Nate Fischer

Modified:
3 years, 9 months ago

Reviewers:

CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow SafeBrowsing in WebView for N and below Apps running on N and below can now enable SafeBrowsing via an opt-in with the metadata flag. Previously, SafeBrowsing could only be enabled for N and below via a CLI switch. BUG=696113

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	android_webview/java/src/org/chromium/android_webview/AwSafeBrowsingConfigHelper.java	View		1 chunk	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nate Fischer

3 years, 9 months ago (2017-03-09 23:11:57 UTC) #5

Message was sent while issue was closed.

We're going with a totally different approach, so this will not be needed

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages