|
|
Chromium Code Reviews|
Created:
3 years, 10 months ago by victorhsieh Modified:
3 years, 9 months ago Reviewers:
Luis Héctor Chávez CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd victorhsieh to arc WATCHLIST
BUG=None
Review-Url: https://codereview.chromium.org/2714293002
Cr-Commit-Position: refs/heads/master@{#453266}
Committed: https://chromium.googlesource.com/chromium/src/+/52feccd87c2102746f7119ab94f4f1aa7fe7a354
Patch Set 1 #Patch Set 2 : Add victorhsieh to arc WATCHLIST #Patch Set 3 : Add victorhsieh to arc WATCHLIST #Messages
Total messages: 18 (10 generated)
The CQ bit was checked by victorhsieh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by victorhsieh@chromium.org
victorhsieh@chromium.org changed reviewers: + lhchavez@chromium.org
The CQ bit was checked by lhchavez@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for WATCHLISTS:
While running git apply --index -p1;
error: patch failed: WATCHLISTS:1493
error: WATCHLISTS: patch does not apply
Patch: WATCHLISTS
Index: WATCHLISTS
diff --git a/WATCHLISTS b/WATCHLISTS
index
b536e2b7d5f0f10747760e5620a05ccb2aa4b4dd..d84dc8be0492982b41f83f0a9d44ea8b8dbd6a5c
100644
--- a/WATCHLISTS
+++ b/WATCHLISTS
@@ -1493,6 +1493,7 @@
'arc': ['elijahtaylor+arcwatch@chromium.org',
'hidehiko+watch@chromium.org',
'lhchavez+watch@chromium.org',
+ 'victorhsieh+watch@chromium.org',
'yusukes+watch@chromium.org'],
'arc_auth': ['khmel+watch@chromium.org'],
'arc_net': ['abhishekbh@chromium.org',
The CQ bit was checked by victorhsieh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lhchavez@chromium.org Link to the patchset: https://codereview.chromium.org/2714293002/#ps40001 (title: "Add victorhsieh to arc WATCHLIST")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488219206174130,
"parent_rev": "708f5678769916057460e6aaad3179e615ab079b", "commit_rev":
"52feccd87c2102746f7119ab94f4f1aa7fe7a354"}
Message was sent while issue was closed.
Description was changed from ========== Add victorhsieh to arc WATCHLIST BUG=None ========== to ========== Add victorhsieh to arc WATCHLIST BUG=None Review-Url: https://codereview.chromium.org/2714293002 Cr-Commit-Position: refs/heads/master@{#453266} Committed: https://chromium.googlesource.com/chromium/src/+/52feccd87c2102746f7119ab94f4... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/52feccd87c2102746f7119ab94f4... |
