Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2714263002: INPUT without focus should be considered as spellcheck disabled (Closed)

Created:
3 years, 10 months ago by Xiaocheng
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT without focus should be considered as spellcheck disabled BUG=696056 Review-Url: https://codereview.chromium.org/2714263002 Cr-Commit-Position: refs/heads/master@{#453041} Committed: https://chromium.googlesource.com/chromium/src/+/eda2b1a7d3a149a67bc9801f126abd7666bba2fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/editing/spelling/no_marker_in_blurred_input.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Xiaocheng
PTAL. It seems that the patch title is sufficiently explanatory....
3 years, 10 months ago (2017-02-25 01:04:01 UTC) #6
yosin_UTC9
lgtm Make sense. Good catch!
3 years, 10 months ago (2017-02-25 01:46:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714263002/1
3 years, 10 months ago (2017-02-25 01:47:14 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 01:52:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eda2b1a7d3a149a67bc9801f126a...

Powered by Google App Engine
This is Rietveld 408576698