Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2714253002: [inspector] disable debugger/pause-on-oom test before further fix (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] disable debugger/pause-on-oom test before further fix It looks like https://codereview.chromium.org/2705293004 changes available space in heap on OOM notification and it produces crash on one of the ports try bot [1]. This test should be more reliable. [1] https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug BUG=v8:6018 TBR=dgozman@chromium.org NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2714253002 Cr-Commit-Position: refs/heads/master@{#43425} Committed: https://chromium.googlesource.com/v8/v8/+/6b7650f03944238afd67274cec634cc511524562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/inspector/inspector.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kozy
I prefer to disable this test then revert relevant CL since CL doesn't change anything ...
3 years, 10 months ago (2017-02-24 22:00:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714253002/1
3 years, 10 months ago (2017-02-24 22:01:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714253002/1
3 years, 10 months ago (2017-02-24 23:42:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714253002/1
3 years, 10 months ago (2017-02-25 00:41:27 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 00:43:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6b7650f03944238afd67274cec634cc5115...

Powered by Google App Engine
This is Rietveld 408576698