Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2714223002: Convert more WaveShaper tests to testharness (Closed)

Created:
3 years, 9 months ago by Raymond Toy
Modified:
3 years, 9 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert more WaveShaper tests to testharness Manually converted test to testharness and new Audit. BUG=688497 TEST=waveshaper-364379.html Review-Url: https://codereview.chromium.org/2714223002 Cr-Commit-Position: refs/heads/master@{#453018} Committed: https://chromium.googlesource.com/chromium/src/+/64d3a68c56929b23455c7cf2e0c8cf5212c9c0cb

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html View 1 2 1 chunk +19 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 9 months ago (2017-02-24 17:15:41 UTC) #2
hongchan
lgtm https://codereview.chromium.org/2714223002/diff/20001/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html File third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html (right): https://codereview.chromium.org/2714223002/diff/20001/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html#newcode1 third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html:1: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <!DOCTYPE ...
3 years, 9 months ago (2017-02-24 23:15:14 UTC) #3
Raymond Toy
https://codereview.chromium.org/2714223002/diff/20001/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html File third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html (right): https://codereview.chromium.org/2714223002/diff/20001/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html#newcode1 third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html:1: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> On 2017/02/24 ...
3 years, 9 months ago (2017-02-24 23:21:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714223002/40001
3 years, 9 months ago (2017-02-24 23:22:31 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-25 00:39:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/64d3a68c56929b23455c7cf2e0c8...

Powered by Google App Engine
This is Rietveld 408576698