Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2714203002: Moved all tests about bypassing CSP into ContentSecurityPolicyTest (Closed)

Created:
3 years, 10 months ago by andypaicu
Modified:
3 years, 9 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved all tests about bypassing CSP into ContentSecurityPolicyTest Removed logic related to bypassing CSP from SourceListDirective Ammended ContentSecurityPolicy to know about blob and filesystem bypasses BUG=692046 Review-Url: https://codereview.chromium.org/2714203002 Cr-Commit-Position: refs/heads/master@{#456353} Committed: https://chromium.googlesource.com/chromium/src/+/3fa8e5f655b856cc26a907d2354502eaefb8232c

Patch Set 1 #

Patch Set 2 : After re-base #

Patch Set 3 : Fixed build errors. Rebase-update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -129 lines) Patch
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 1 5 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 2 11 chunks +21 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 1 2 2 chunks +129 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp View 1 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp View 1 2 chunks +0 lines, -95 lines 0 comments Download

Messages

Total messages: 20 (17 generated)
Mike West
LGTM! Looks like you'll need to rebase this, however.
3 years, 9 months ago (2017-03-02 10:50:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714203002/40001
3 years, 9 months ago (2017-03-13 11:27:41 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 11:33:04 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3fa8e5f655b856cc26a907d23545...

Powered by Google App Engine
This is Rietveld 408576698