Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 27142002: Use DEFINE_NODE_TYPE_CASTS instead of using manual toHTMLFooElement() (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, gavinp+prerender_chromium.org, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use DEFINE_NODE_TYPE_CASTS instead of using manual toHTMLFooElement() Replace manual toHTMLFooElement() with DEFINE_NODE_TYPE_CASTS(). It supports more various helper functions as well as we can use it easily. However, this cl only can cover toHTMLFooElement() except for non-support toHTMLFooElement(). BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -216 lines) Patch
M Source/core/html/HTMLBodyElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLDataListElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLDialogElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLDivElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLFrameElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -11 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLHeadElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 chunk +1 line, -11 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +1 line, -15 lines 0 comments Download
M Source/core/html/HTMLLegendElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLMapElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLMetaElement.h View 1 chunk +1 line, -11 lines 0 comments Download
M Source/core/html/HTMLOListElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLOptionElement.h View 1 chunk +1 line, -13 lines 0 comments Download
M Source/core/html/HTMLParamElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/html/HTMLScriptElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/html/HTMLSourceElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLStyleElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLTableCaptionElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLTrackElement.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-10-14 02:17:53 UTC) #1
gyuyoung-inactive
7 years, 2 months ago (2013-10-15 05:53:02 UTC) #2
gyuyoung-inactive
7 years, 2 months ago (2013-10-15 05:53:04 UTC) #3
tkent
lgtm Thanks!
7 years, 2 months ago (2013-10-16 00:38:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/27142002/1
7 years, 2 months ago (2013-10-16 00:39:01 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 09:52:23 UTC) #6
Message was sent while issue was closed.
Change committed as 159740

Powered by Google App Engine
This is Rietveld 408576698