Source/core/html/HTMLSelectElement.h - Issue 27142002: Use DEFINE_NODE_TYPE_CASTS instead of using manual toHTMLFooElement()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 27142002: Use DEFINE_NODE_TYPE_CASTS instead of using manual toHTMLFooElement() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.h

diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h

index 83b20621f359e3343746cb98c4c14b2e94701dd7..6670342d74e6aaf50f452ebfcbaaa34c30e1cfcf 100644

--- a/Source/core/html/HTMLSelectElement.h

+++ b/Source/core/html/HTMLSelectElement.h

@@ -211,13 +211,7 @@ private:

bool m_isParsingInProgress;

};

-inline HTMLSelectElement* toHTMLSelectElement(Node* node)

- ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(HTMLNames::selectTag));

- return static_cast<HTMLSelectElement*>(node);

-void toHTMLSelectElement(const HTMLSelectElement*); // This overload will catch anyone doing an unnecessary cast.

+DEFINE_NODE_TYPE_CASTS(HTMLSelectElement, hasTagName(HTMLNames::selectTag));

} // namespace

« no previous file with comments | « Source/core/html/HTMLScriptElement.h ('k') | Source/core/html/HTMLSourceElement.h » ('j') | no next file with comments »