[Mac RTL] Fix the RTLness of the website settings bubble header.

[Mac RTL] Fix the RTLness of the website settings bubble header.

BUG=696009
Review-Url: https://codereview.chromium.org/2714193004
Cr-Commit-Position: refs/heads/master@{#468159}
Committed: https://chromium.googlesource.com/chromium/src/+/ae182230f56e92bc952ba62c8d6800e56f206008

[Avi (use Gerrit), 2017-02-24 21:54:15]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 21:55:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-02-24 21:55:40]

avi@chromium.org changed reviewers:
+ lgrey@chromium.org

[lgrey, 2017-02-24 22:11:57]

LGTM

https://codereview.chromium.org/2714193004/diff/1/chrome/browser/ui/cocoa/web...
File
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
(right):

https://codereview.chromium.org/2714193004/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm:357:
securityDetailsField_.alignment = NSRightTextAlignment;
Would an unconditional NSNaturalTextAlignment work here?

[commit-bot: I haz the power, 2017-02-24 22:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:18:31]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-02-27 16:51:42]

https://codereview.chromium.org/2714193004/diff/1/chrome/browser/ui/cocoa/web...
File
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
(right):

https://codereview.chromium.org/2714193004/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm:357:
securityDetailsField_.alignment = NSRightTextAlignment;
On 2017/02/24 22:11:56, lgrey wrote:
> Would an unconditional NSNaturalTextAlignment work here?

No; when I try it out it keeps left aligning the text. Not sure why.

[Avi (use Gerrit), 2017-02-27 16:51:47]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:52:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 16:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:52:07]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Avi (use Gerrit), 2017-04-28 05:31:04]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:31:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:31:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:31:22]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Avi (use Gerrit), 2017-04-28 05:40:07]

avi@chromium.org changed reviewers:
+ rsesek@chromium.org

[Avi (use Gerrit), 2017-04-28 05:40:08]

Wow, this got lost. Found it during cleanup.

[Robert Sesek, 2017-04-28 16:20:42]

lgtm

[Avi (use Gerrit), 2017-04-28 16:50:24]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-04-28 16:50:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 16:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 16:55:24]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2017-04-28 21:59:21]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-04-28 21:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
lgrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2714193004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-28 22:00:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 22:34:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493416761847210,
"parent_rev": "6016778c99f93e8f91eec1d1f20fc44642d3bfde", "commit_rev":
"ae182230f56e92bc952ba62c8d6800e56f206008"}

[commit-bot: I haz the power, 2017-04-28 22:34:48]

Description was changed from

==========
[Mac RTL] Fix the RTLness of the website settings bubble header.

BUG=696009
==========

to

==========
[Mac RTL] Fix the RTLness of the website settings bubble header.

BUG=696009

Review-Url: https://codereview.chromium.org/2714193004
Cr-Commit-Position: refs/heads/master@{#468159}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae182230f56e92bc952ba62c8d68...
==========

[commit-bot: I haz the power, 2017-04-28 22:34:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ae182230f56e92bc952ba62c8d68...