Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2714103002: Revert of Make disabling 2d canvas GPU acceleration for getImageData less aggressive. (Closed)

Created:
3 years, 9 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, Stephen Chennney, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis, Jin Yang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make disabling 2d canvas GPU acceleration for getImageData less aggressive. (patchset #4 id:60001 of https://codereview.chromium.org/2687073003/ ) Reason for revert: Caused http://crbug.com/695471 -- regressions of 2D/WebGL canvas test on Linux AMD. Original issue's description: > Make disabling 2d canvas GPU acceleration for getImageData less aggressive. > > Make canvas switch out of gpu acceleration only when getImageData is > called in successive frames. This will avoid disabling gpu acceleration > when getImageData is only called once or is called very rarely. > > BUG=690122 > > Review-Url: https://codereview.chromium.org/2687073003 > Cr-Commit-Position: refs/heads/master@{#451998} > Committed: https://chromium.googlesource.com/chromium/src/+/c36340833135933c5934ece592fb41b82743e2d8 TBR=junov@chromium.org,xiangze.zhang@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=690122 Review-Url: https://codereview.chromium.org/2714103002 Cr-Commit-Position: refs/heads/master@{#452968} Committed: https://chromium.googlesource.com/chromium/src/+/c9b8e77314a6de607cddd12813265638d13b5355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -44 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 chunk +3 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 4 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ken Russell (switch to Gerrit)
Created Revert of Make disabling 2d canvas GPU acceleration for getImageData less aggressive.
3 years, 9 months ago (2017-02-24 07:01:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714103002/1
3 years, 9 months ago (2017-02-24 07:01:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/372859)
3 years, 9 months ago (2017-02-24 07:29:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714103002/1
3 years, 9 months ago (2017-02-24 21:22:39 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 22:48:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9b8e77314a6de607cddd1281326...

Powered by Google App Engine
This is Rietveld 408576698